Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing return type matchers to the executor instrumentation #5294

Merged

Conversation

mateuszrzeszutek
Copy link
Member

This should fix the instrumentation errors observed in #5293 (no idea about grpc propagation though)

@mateuszrzeszutek mateuszrzeszutek requested a review from a team February 2, 2022 17:44
Comment on lines -51 to +58
nameMatches("invoke(Any|All)$").and(takesArgument(0, Collection.class)),
namedOneOf("invokeAny", "invokeAll").and(takesArgument(0, Collection.class)),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment on lines -55 to +62
nameMatches("invoke").and(takesArgument(0, ForkJoinTask.class)),
named("invoke").and(takesArgument(0, ForkJoinTask.class)),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@trask trask merged commit 21f968a into open-telemetry:main Feb 2, 2022
RashmiRam pushed a commit to RashmiRam/opentelemetry-auto-instr-java that referenced this pull request May 23, 2022
@mateuszrzeszutek mateuszrzeszutek deleted the fix-executor-instrumentation branch November 18, 2022 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants